Bug 133331

Summary: Use correct version of requiresFullscreenForVideoPlayback().
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, jonlee, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jeremy Jones
Reported 2014-05-27 18:56:04 PDT
Use correct version of requiresFullscreenForVideoPlayback().
Attachments
Patch (1.56 KB, patch)
2014-05-27 19:04 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch (4.86 KB, patch)
2014-05-28 16:44 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2014-05-27 18:57:00 PDT
radar://16478742
Jeremy Jones
Comment 2 2014-05-27 19:04:08 PDT
Created attachment 232162 [details] Patch
Eric Carlson
Comment 3 2014-05-28 06:34:59 PDT
Comment on attachment 232162 [details] Patch This should have a layout test. You can use video-fullscreeen-only-playback.html as a template, although a test for this will be much simpler.
Jeremy Jones
Comment 4 2014-05-28 16:44:24 PDT
Created attachment 232220 [details] Patch
Eric Carlson
Comment 5 2014-05-28 18:52:39 PDT
Comment on attachment 232220 [details] Patch Thanks!
WebKit Commit Bot
Comment 6 2014-05-29 09:27:17 PDT
Comment on attachment 232220 [details] Patch Clearing flags on attachment: 232220 Committed r169449: <http://trac.webkit.org/changeset/169449>
WebKit Commit Bot
Comment 7 2014-05-29 09:27:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.