Bug 133331 - Use correct version of requiresFullscreenForVideoPlayback().
Summary: Use correct version of requiresFullscreenForVideoPlayback().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-27 18:56 PDT by Jeremy Jones
Modified: 2014-05-29 09:27 PDT (History)
11 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2014-05-27 19:04 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Patch (4.86 KB, patch)
2014-05-28 16:44 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2014-05-27 18:56:04 PDT 
Use correct version of requiresFullscreenForVideoPlayback().
Comment 1 Jeremy Jones 2014-05-27 18:57:00 PDT 
radar://16478742
Comment 2 Jeremy Jones 2014-05-27 19:04:08 PDT 
Created attachment 232162 [details]
Patch
Comment 3 Eric Carlson 2014-05-28 06:34:59 PDT 
Comment on attachment 232162 [details]
Patch

This should have a layout test. You can use video-fullscreeen-only-playback.html as a template, although a test for this will be much simpler.
Comment 4 Jeremy Jones 2014-05-28 16:44:24 PDT 
Created attachment 232220 [details]
Patch
Comment 5 Eric Carlson 2014-05-28 18:52:39 PDT 
Comment on attachment 232220 [details]
Patch

Thanks!
Comment 6 WebKit Commit Bot 2014-05-29 09:27:17 PDT 
Comment on attachment 232220 [details]
Patch

Clearing flags on attachment: 232220

Committed r169449: <http://trac.webkit.org/changeset/169449>
Comment 7 WebKit Commit Bot 2014-05-29 09:27:21 PDT 
All reviewed patches have been landed.  Closing bug.