Bug 133325

Summary:

Move constructTextRun() from RenderBlock to RenderBox

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

joepeck

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Myles C. Maxfield 2014-05-27 14:50:27 PDT

Move constructTextRun() from RenderBlock to RenderBox

Comment 1 Myles C. Maxfield 2014-05-27 14:53:36 PDT

Created attachment 232150 [details]
Patch

Comment 2 zalan 2014-06-10 18:59:31 PDT

Comment on attachment 232150 [details]
Patch

Is there a reason why we keep these stateless functions around in a render class instead of a separate file?

Comment 3 Myles C. Maxfield 2014-06-11 14:32:35 PDT

I am not 100% sure but my guess would be to keep relevant pieces nearby

Comment 4 Joseph Pecoraro 2015-11-12 21:37:48 PST

Comment on attachment 232150 [details]
Patch

Does this patch still make sense?