Bug 133295

Summary:

CSS JIT: add support for the pseudo classes :hover and :active

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, japhet, jer.noble, kangil.han, kling, kondapallykalyan, philipj, rniwa, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

133314

Attachments:

Description	Flags
Patch	none

Benjamin Poulain

Reported 2014-05-26 20:23:03 PDT

CSS JIT: add support for the pseudo classes :hover and :active

Attachments
Patch (38.07 KB, patch) 2014-05-26 20:31 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2014-05-26 20:31:17 PDT

Created attachment 232104 [details] Patch

Andreas Kling

Comment 2 2014-05-27 10:22:39 PDT

Comment on attachment 232104 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232104&action=review > Source/WebCore/dom/Document.cpp:767 > +void Document::setCompatibilityMode(DocumentCompatibilityMode mode) Does this function need to do any additional invalidation?

Benjamin Poulain

Comment 3 2014-05-27 15:47:31 PDT

(In reply to comment #2) > (From update of attachment 232104 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232104&action=review > > > Source/WebCore/dom/Document.cpp:767 > > +void Document::setCompatibilityMode(DocumentCompatibilityMode mode) > > Does this function need to do any additional invalidation? That should not be needed. With compiled selectors we don't even need the clearSelectorQueryCache(), it is just there for the old code.

Andreas Kling

Comment 4 2014-05-29 15:37:55 PDT

Comment on attachment 232104 [details] Patch r=me

Benjamin Poulain

Comment 5 2014-05-29 17:15:44 PDT

Comment on attachment 232104 [details] Patch Clearing flags on attachment: 232104 Committed r169478: <http://trac.webkit.org/changeset/169478>

Benjamin Poulain

Comment 6 2014-05-29 17:15:49 PDT

All reviewed patches have been landed. Closing bug.

Ryosuke Niwa

Comment 7 2014-06-01 02:03:43 PDT

Looks like this was 0.88% improvement on DYEBench: https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mavericks%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%2C%5B%22mac-mavericks%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%5D&zoom=%5B1401260360227.201%2C1401458178404.44%5D

Benjamin Poulain

Comment 8 2014-06-01 02:14:35 PDT

(In reply to comment #7) > Looks like this was 0.88% improvement on DYEBench: > https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mavericks%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%2C%5B%22mac-mavericks%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%5D&zoom=%5B1401260360227.201%2C1401458178404.44%5D Nice!

Note You need to log in before you can comment on or make changes to this bug.