| Summary: | CSS JIT: add support for the pseudo classes :hover and :active | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, japhet, jer.noble, kangil.han, kling, kondapallykalyan, philipj, rniwa, sergio | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 133314 | ||||||
| Attachments: |
|
||||||
|
Description
Benjamin Poulain
2014-05-26 20:23:03 PDT
Created attachment 232104 [details]
Patch
Comment on attachment 232104 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232104&action=review > Source/WebCore/dom/Document.cpp:767 > +void Document::setCompatibilityMode(DocumentCompatibilityMode mode) Does this function need to do any additional invalidation? (In reply to comment #2) > (From update of attachment 232104 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232104&action=review > > > Source/WebCore/dom/Document.cpp:767 > > +void Document::setCompatibilityMode(DocumentCompatibilityMode mode) > > Does this function need to do any additional invalidation? That should not be needed. With compiled selectors we don't even need the clearSelectorQueryCache(), it is just there for the old code. Comment on attachment 232104 [details]
Patch
r=me
Comment on attachment 232104 [details] Patch Clearing flags on attachment: 232104 Committed r169478: <http://trac.webkit.org/changeset/169478> All reviewed patches have been landed. Closing bug. Looks like this was 0.88% improvement on DYEBench: https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mavericks%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%2C%5B%22mac-mavericks%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%5D&zoom=%5B1401260360227.201%2C1401458178404.44%5D (In reply to comment #7) > Looks like this was 0.88% improvement on DYEBench: > https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mavericks%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%2C%5B%22mac-mavericks%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%5D&zoom=%5B1401260360227.201%2C1401458178404.44%5D Nice! |