Bug 133254

Summary:

Rename ScrollingTreeScrollingNode's m_scrollPosition to make it clear that it's the value committed from the state tree

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Simon Fraser (smfr) 2014-05-23 20:55:16 PDT

Rename ScrollingTreeScrollingNode's m_scrollPosition to make it clear that it's the value committed from the state tree

Comment 1 Simon Fraser (smfr) 2014-05-23 20:56:33 PDT

Created attachment 232015 [details]
Patch

Comment 2 Simon Fraser (smfr) 2014-05-23 20:56:59 PDT

Sits on top of an earlier patch.

Comment 3 Tim Horton 2014-05-23 21:01:01 PDT

Comment on attachment 232015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232015&action=review

> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:62
> +        m_lastCommittedcrollPosition = state.scrollPosition();

where did the s go

Comment 4 Simon Fraser (smfr) 2014-05-24 13:41:15 PDT

https://trac.webkit.org/r169313