Bug 133238

Summary: run-perf-tests should ignore whitespace lines when snarfing test output
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, mhahnenberg, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 133054    
Attachments:
Description Flags
Patch rniwa: review+

Geoffrey Garen
Reported 2014-05-23 15:13:10 PDT
run-perf-tests should ignore whitespace lines when snarfing test output
Attachments
Patch (1.78 KB, patch)
2014-05-23 15:14 PDT, Geoffrey Garen 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2014-05-23 15:14:35 PDT
Created attachment 231996 [details] Patch
Geoffrey Garen
Comment 2 2014-05-23 15:37:44 PDT
Committed r169286: <http://trac.webkit.org/changeset/169286>
Mark Hahnenberg
Comment 3 2014-05-23 16:29:57 PDT
(In reply to comment #2) > Committed r169286: <http://trac.webkit.org/changeset/169286> It looks like this broke some webkitpy tests on the Mavericks WK2 Release bots: For the output of the failing tests, see: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20(Tests)/builds/5931/steps/webkitpy-test/logs/stdio For the history of when the tests started failing, see: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20%28Tests%29?numbuilds=25
Ryosuke Niwa
Comment 4 2014-05-23 19:07:17 PDT
Fixed in http://trac.webkit.org/changeset/169289.
Note You need to log in before you can comment on or make changes to this bug.