Summary: | Disable external playback while video plays inline with mirroring. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jeremy Jones <jeremyj-wk> | ||||||||
Component: | New Bugs | Assignee: | Jeremy Jones <jeremyj-wk> | ||||||||
Status: | RESOLVED DUPLICATE | ||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, eric.carlson, glenn, jer.noble, philipj, rniwa, sergio | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Jeremy Jones
2014-05-23 10:37:59 PDT
Created attachment 231974 [details]
Patch
Comment on attachment 231974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231974&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2327 > + UIScreenType *mainScreen = [UIScreen mainScreen]; > + for (UIScreenType *screen in [UIScreen screens]) { > + if (![screen isEqual:mainScreen] && [screen.mirroredScreen isEqual:mainScreen]) { > + isMainScreenMirrored = true; > + break; > + } > + } Nit: you can skip this if when in fullscreen. Comment on attachment 231974 [details] Patch Attachment 231974 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6176511719636992 New failing tests: media/media-fragments/TC0001.html Created attachment 231986 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 231974 [details] Patch Attachment 231974 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4941080214634496 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html Created attachment 231993 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
superseded by: 133829 *** This bug has been marked as a duplicate of bug 133829 *** |