Bug 133221

Summary: navigator object needs to have properties directly on the instance object
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, cgarcia, commit-queue, dbates, mhahnenberg, mitz
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=154304
Attachments:
Description Flags
Patch mark.lam: review+

Oliver Hunt
Reported 2014-05-23 09:58:35 PDT
navigator object needs to have properties directly on the instance object
Attachments
Patch (1.51 KB, patch)
2014-05-23 10:02 PDT, Oliver Hunt 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2014-05-23 10:02:16 PDT
Created attachment 231970 [details] Patch
Mark Lam
Comment 2 2014-05-23 10:05:00 PDT
Comment on attachment 231970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231970&action=review r=me with comment fix. > Source/WebCore/ChangeLog:9 > + as there were a few compatability issues when on the prototype. s/compatability/compatibility/
Alexey Proskuryakov
Comment 3 2014-05-23 10:07:02 PDT
Comment on attachment 231970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231970&action=review >> Source/WebCore/ChangeLog:9 >> + as there were a few compatability issues when on the prototype. > > s/compatability/compatibility/ Is there a way to discover what the issues were (perhaps a Radar?)
Oliver Hunt
Comment 4 2014-05-23 10:08:52 PDT
Committed r169260: <http://trac.webkit.org/changeset/169260>
Oliver Hunt
Comment 5 2014-05-23 10:10:12 PDT
rdar://16332749
Mark Hahnenberg
Comment 6 2014-05-23 11:10:32 PDT
(In reply to comment #4) > Committed r169260: <http://trac.webkit.org/changeset/169260> This appears to have broken the following tests on the WK2 bots: fast/dom/Geolocation/enabled.html js/dom/delete-syntax.html Here's a link to the test results: http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r169260%20(5917)/results.html Here's a link to the history of test results: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20%28Tests%29?numbuilds=25
Note You need to log in before you can comment on or make changes to this bug.