| Summary: | navigator object needs to have properties directly on the instance object | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||
| Component: | New Bugs | Assignee: | Oliver Hunt <oliver> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, cdumez, cgarcia, commit-queue, dbates, mhahnenberg, mitz | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=154304 | ||||||
| Attachments: |
|
||||||
|
Description
Oliver Hunt
2014-05-23 09:58:35 PDT
Created attachment 231970 [details]
Patch
Comment on attachment 231970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231970&action=review r=me with comment fix. > Source/WebCore/ChangeLog:9 > + as there were a few compatability issues when on the prototype. s/compatability/compatibility/ Comment on attachment 231970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231970&action=review >> Source/WebCore/ChangeLog:9 >> + as there were a few compatability issues when on the prototype. > > s/compatability/compatibility/ Is there a way to discover what the issues were (perhaps a Radar?) Committed r169260: <http://trac.webkit.org/changeset/169260> (In reply to comment #4) > Committed r169260: <http://trac.webkit.org/changeset/169260> This appears to have broken the following tests on the WK2 bots: fast/dom/Geolocation/enabled.html js/dom/delete-syntax.html Here's a link to the test results: http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r169260%20(5917)/results.html Here's a link to the history of test results: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20%28Tests%29?numbuilds=25 |