Bug 133203

Summary:

Use type-checking FilterOperation casts in CoordinatedGraphicsArgumentCoders.cpp

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

Platform

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, buildbot, bunhere, cmarcelo, commit-queue, gyuyoung.kim, luiz, noam, rniwa, sergio, simon.fraser, zeno

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

131142

Bug Blocks:

Attachments:

Description	Flags
Patch v1	none
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2	none

David Kilzer (:ddkilzer)

Reported 2014-05-22 21:36:16 PDT

This is a follow-up to Bug 131142 (commit r166741) which missed some static_cast<>() operators in Source/WebKit2.

Attachments
Patch v1 (3.81 KB, patch) 2014-05-22 21:49 PDT, David Kilzer (:ddkilzer)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (652.45 KB, application/zip) 2014-05-23 03:55 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2014-05-22 21:49:34 PDT

Created attachment 231940 [details] Patch v1

Build Bot

Comment 2 2014-05-23 03:55:49 PDT

Comment on attachment 231940 [details] Patch v1 Attachment 231940 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5430066267815936 New failing tests: media/W3C/video/src/src_reflects_attribute_not_source_elements.html

Build Bot

Comment 3 2014-05-23 03:55:54 PDT

Created attachment 231955 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

David Kilzer (:ddkilzer)

Comment 4 2014-05-23 12:53:49 PDT

(In reply to comment #2) > (From update of attachment 231940 [details]) > Attachment 231940 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.appspot.com/results/5430066267815936 > > New failing tests: > media/W3C/video/src/src_reflects_attribute_not_source_elements.html This does not appear to be related to this change.

WebKit Commit Bot

Comment 5 2014-05-25 11:00:39 PDT

Comment on attachment 231940 [details] Patch v1 Clearing flags on attachment: 231940 Committed r169319: <http://trac.webkit.org/changeset/169319>

WebKit Commit Bot

Comment 6 2014-05-25 11:00:48 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.