Summary: | [EFL] Input fields and text areas are not rendered correctly after r167771 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michal Pakula vel Rutka <mpakulavelrutka> | ||||||||
Component: | WebKit EFL | Assignee: | Michal Pakula vel Rutka <mpakulavelrutka> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rniwa, sergio | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Michal Pakula vel Rutka
2014-05-22 08:45:35 PDT
Created attachment 231964 [details] proposed patch r167771 introduced changes in methods in parent (RenderTheme) class which were not reflected in derived class (RenderThemeEfl) Comment on attachment 231964 [details] proposed patch Attachment 231964 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4660147745980416 New failing tests: media/W3C/video/readyState/readyState_during_canplay.html Created attachment 231978 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 231964 [details]
proposed patch
Looks fine.
Comment on attachment 231964 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=231964&action=review > Source/WebCore/platform/efl/RenderThemeEfl.h:66 > ~RenderThemeEfl(); nit: would be nice to mark this destructor explicitly as virtual since you are cleaning up. Created attachment 232062 [details]
applied Christophe's suggestion
Comment on attachment 232062 [details] applied Christophe's suggestion Clearing flags on attachment: 232062 Committed r169335: <http://trac.webkit.org/changeset/169335> All reviewed patches have been landed. Closing bug. |