| Summary: | Text markers don't paint on simple lines | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, commit-queue, esprehn+autocc, kangil.han, koivisto, ossy, thorton | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antti Koivisto
2014-05-22 05:50:48 PDT
Created attachment 231879 [details]
patch
(In reply to comment #1) > Created an attachment (id=231879) [details] > patch It broke the Apple Windows build: 1>WebCoreTestSupport.lib(Internals.obj) : error LNK2019: unresolved external symbol "public: void __thiscall WebCore::Editor::setMarkedTextMatchesAreHighlighted(bool)" (?setMarkedTextMatchesAreHighlighted@Editor@WebCore@@QAEX_N@Z) referenced in function "public: void __thiscall WebCore::Internals::setMarkedTextMatchesAreHighlighted(bool,int &)" (?setMarkedTextMatchesAreHighlighted@Internals@WebCore@@QAEX_NAAH@Z) 1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(607,5): error MSB6006: "link.exe" exited with code 1120. 1>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\DumpRenderTree.dll : fatal error LNK1120: 1 unresolved externals 1>Done Building Project "C:\cygwin\home\buildbot\slave\win-release\build\Tools\DumpRenderTree\DumpRenderTree.vcxproj\DumpRenderTree\DumpRenderTree.vcxproj" (Build target(s)) -- FAILED. The Windows build is still broken. Are you going to fix it? (In reply to comment #4) > The Windows build is still broken. Are you going to fix it? http://trac.webkit.org/changeset/169253 fixed the build, thanks. |