Bug 133176

Summary: W3C test importer should catch exceptions coming from HTML/CSS conversion
Product: WebKit Reporter: youenn fablet <youennf>
Component: Tools / TestsAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, commit-queue, glenn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2014-05-22 05:31:31 PDT
Test case W3C test html/semantics/forms/the-input-element/radio-groupname-case.html breaks W3C test importer. An exception is raised within python 2.7 HTMLParser. This stops the conversion process. It may be better to catch the exception, log it and continue importing the remaining tests.
Attachments
Patch (3.14 KB, patch)
2014-05-22 05:43 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (3.14 KB, patch)
2014-05-22 06:01 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2014-05-22 05:43:07 PDT
Created attachment 231877 [details] Patch
WebKit Commit Bot
Comment 2 2014-05-22 05:45:53 PDT
Attachment 231877 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/w3c/test_importer.py:346: trailing whitespace [pep8/W291] [5] ERROR: Tools/Scripts/webkitpy/w3c/test_importer.py:350: multiple statements on one line (semicolon) [pep8/E702] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
youenn fablet
Comment 3 2014-05-22 06:01:04 PDT
Created attachment 231880 [details] Patch
WebKit Commit Bot
Comment 4 2014-05-26 09:11:46 PDT
Comment on attachment 231880 [details] Patch Clearing flags on attachment: 231880 Committed r169347: <http://trac.webkit.org/changeset/169347>
WebKit Commit Bot
Comment 5 2014-05-26 09:11:51 PDT
All reviewed patches have been landed. Closing bug.
Carlos Alberto Lopez Perez
Comment 6 2014-05-26 16:15:15 PDT
(In reply to comment #3) > Created an attachment (id=231880) [details] > Patch (In reply to comment #4) > (From update of attachment 231880 [details]) > Clearing flags on attachment: 231880 > > Committed r169347: <http://trac.webkit.org/changeset/169347> This broke the webkitpy tests on all platforms: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/6279
youenn fablet
Comment 7 2014-05-26 23:48:21 PDT
(In reply to comment #6) > (In reply to comment #3) > > Created an attachment (id=231880) [details] [details] > > Patch > > (In reply to comment #4) > > (From update of attachment 231880 [details] [details]) > > Clearing flags on attachment: 231880 > > > > Committed r169347: <http://trac.webkit.org/changeset/169347> > > > This broke the webkitpy tests on all platforms: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/6279 Gyuyoung fixed it at http://trac.webkit.org/changeset/169369
Note You need to log in before you can comment on or make changes to this bug.