Summary: | W3C test importer should catch exceptions coming from HTML/CSS conversion | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | Tools / Tests | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | clopez, commit-queue, glenn | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
youenn fablet
2014-05-22 05:31:31 PDT
Created attachment 231877 [details]
Patch
Attachment 231877 [details] did not pass style-queue:
ERROR: Tools/Scripts/webkitpy/w3c/test_importer.py:346: trailing whitespace [pep8/W291] [5]
ERROR: Tools/Scripts/webkitpy/w3c/test_importer.py:350: multiple statements on one line (semicolon) [pep8/E702] [5]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 231880 [details]
Patch
Comment on attachment 231880 [details] Patch Clearing flags on attachment: 231880 Committed r169347: <http://trac.webkit.org/changeset/169347> All reviewed patches have been landed. Closing bug. (In reply to comment #3) > Created an attachment (id=231880) [details] > Patch (In reply to comment #4) > (From update of attachment 231880 [details]) > Clearing flags on attachment: 231880 > > Committed r169347: <http://trac.webkit.org/changeset/169347> This broke the webkitpy tests on all platforms: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/6279 (In reply to comment #6) > (In reply to comment #3) > > Created an attachment (id=231880) [details] [details] > > Patch > > (In reply to comment #4) > > (From update of attachment 231880 [details] [details]) > > Clearing flags on attachment: 231880 > > > > Committed r169347: <http://trac.webkit.org/changeset/169347> > > > This broke the webkitpy tests on all platforms: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/6279 Gyuyoung fixed it at http://trac.webkit.org/changeset/169369 |