| Summary: | Don't create huge backing stores when transforms cause layer scaling | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED WONTFIX | ||||||||
| Severity: | Normal | CC: | buildbot, dino, rniwa, simon.fraser, thorton | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2014-05-21 22:25:15 PDT
Created attachment 231857 [details]
Patch
Comment on attachment 231857 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231857&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2170 > + for (size_t i = 0; i < animations.size(); ++i) { range-based for? > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2172 > + runningAnimations.remove(currAnimationName); can you use the iterator from earlier? > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2443 > + for (auto it = animations.begin(); it != animations.end(); ++it) { range-based for here too, maybe? Comment on attachment 231857 [details] Patch Attachment 231857 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6102868599767040 New failing tests: media/media-source/media-source-addsourcebuffer.html Created attachment 231886 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 231857 [details]
Patch
Not going to do this.
|