Summary: | [GTK] Allow to run the tests on the native X display (instead of running them inside of Xvfb) | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, cgarcia, clopez, commit-queue, glenn, mrobinson, ossy, pnormand, rniwa, zsborbely.u-szeged | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 132862, 144247 | ||||||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2014-05-21 13:14:28 PDT
Created attachment 231957 [details]
Patch
Comment on attachment 231957 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231957&action=review Quick questions > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:131 > + optparse.make_option("--nocheck-sys-deps", action="store_true", default=False, > + help="Don't check the system dependencies (themes, fonts, ...)"), Is this really necessary? > Tools/Scripts/webkitpy/port/driver.py:493 > + def check_driver(port): Where is it used? (In reply to comment #2) > (From update of attachment 231957 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231957&action=review > > Quick questions > > > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:131 > > + optparse.make_option("--nocheck-sys-deps", action="store_true", default=False, > > + help="Don't check the system dependencies (themes, fonts, ...)"), > > Is this really necessary? > Not strictly necessary, but is consistent with the script for running the layout tests run-webkit-tests: $ Tools/Scripts/run-webkit-tests --help|grep sys --nocheck-sys-deps Don't check the system dependencies (themes) I can drop it, if you think is better. > > Tools/Scripts/webkitpy/port/driver.py:493 > > + def check_driver(port): > > Where is it used? Is used on the drivers Xvfb, Weston and this new one (xorgdriver): Tools/Scripts/webkitpy/port/xvfbdriver.py Tools/Scripts/webkitpy/port/westondriver.py Comment on attachment 231957 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231957&action=review >>> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:131 >>> + help="Don't check the system dependencies (themes, fonts, ...)"), >> >> Is this really necessary? > > Not strictly necessary, but is consistent with the script for running the layout tests run-webkit-tests: > > $ Tools/Scripts/run-webkit-tests --help|grep sys > --nocheck-sys-deps Don't check the system dependencies (themes) > > I can drop it, if you think is better. Unless it is necessary, let's drop this. It is trivial to add later if needed. Created attachment 232074 [details]
Patch
(In reply to comment #4) > (From update of attachment 231957 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231957&action=review > > >>> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:131 > >>> + help="Don't check the system dependencies (themes, fonts, ...)"), > >> > >> Is this really necessary? > > > > Not strictly necessary, but is consistent with the script for running the layout tests run-webkit-tests: > > > > $ Tools/Scripts/run-webkit-tests --help|grep sys > > --nocheck-sys-deps Don't check the system dependencies (themes) > > > > I can drop it, if you think is better. > > Unless it is necessary, let's drop this. > It is trivial to add later if needed. Thanks for your review :) I have re-uploaded the patch without the "--nocheck-sys-deps" option Created attachment 232077 [details]
Patch
(In reply to comment #7) > Created an attachment (id=232077) [details] > Patch I have re-uploaded it again with the "Reviewed by" bit pre-filled on the Changelog. Can someone cq+ it for me please? Thanks! Comment on attachment 232077 [details] Patch Clearing flags on attachment: 232077 Committed r169344: <http://trac.webkit.org/changeset/169344> All reviewed patches have been landed. Closing bug. |