| Summary: | Special handling of telephone number detection menu | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
| Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | thorton | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Mac | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Brady Eidson
2014-05-20 21:09:47 PDT
Created attachment 231813 [details]
Patch v1
Comment on attachment 231813 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=231813&action=review r=me > Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:462 > + // In the future all other menus we should probably eiher use that API or the This comment confused me a little, because it seemed like you were saying that it's a FIXME that telephone number menus use this API. But I think you're actually saying that telephone menus are better than all other menus, and it's a FIXME to fix the other menus. So, maybe put the FIXME before the second sentence instead of the first? Also: Typos in "other menus we should probably eiher use". |