Bug 133143

Summary: Special handling of telephone number detection menu
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch v1 ggaren: review+

Brady Eidson
Reported 2014-05-20 21:09:47 PDT
Special handling of telephone number detection menu In radar as <rdar://problem/16967971>
Attachments
Patch v1 (9.37 KB, patch)
2014-05-20 21:31 PDT, Brady Eidson 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2014-05-20 21:31:12 PDT
Created attachment 231813 [details] Patch v1
Geoffrey Garen
Comment 2 2014-05-21 10:31:46 PDT
Comment on attachment 231813 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=231813&action=review r=me > Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:462 > + // In the future all other menus we should probably eiher use that API or the This comment confused me a little, because it seemed like you were saying that it's a FIXME that telephone number menus use this API. But I think you're actually saying that telephone menus are better than all other menus, and it's a FIXME to fix the other menus. So, maybe put the FIXME before the second sentence instead of the first? Also: Typos in "other menus we should probably eiher use".
Brady Eidson
Comment 3 2014-05-21 10:55:02 PDT
http://trac.webkit.org/changeset/169170
Note You need to log in before you can comment on or make changes to this bug.