Bug 133143 - Special handling of telephone number detection menu
Summary: Special handling of telephone number detection menu
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
Keywords: InRadar
Depends on:
Reported: 2014-05-20 21:09 PDT by Brady Eidson
Modified: 2014-05-21 10:55 PDT (History)
1 user (show)

See Also:

Patch v1 (9.37 KB, patch)
2014-05-20 21:31 PDT, Brady Eidson
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-05-20 21:09:47 PDT
Special handling of telephone number detection menu

In radar as <rdar://problem/16967971>
Comment 1 Brady Eidson 2014-05-20 21:31:12 PDT
Created attachment 231813 [details]
Patch v1
Comment 2 Geoffrey Garen 2014-05-21 10:31:46 PDT
Comment on attachment 231813 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=231813&action=review


> Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:462
> +    // In the future all other menus we should probably eiher use that API or the

This comment confused me a little, because it seemed like you were saying that it's a FIXME that telephone number menus use this API. But I think you're actually saying that telephone menus are better than all other menus, and it's a FIXME to fix the other menus.

So, maybe put the FIXME before the second sentence instead of the first?

Also: Typos in "other menus we should probably eiher use".
Comment 3 Brady Eidson 2014-05-21 10:55:02 PDT