Bug 133135

Summary: Watchdog timer should be lazily allocated
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mark Hahnenberg
Reported 2014-05-20 14:01:00 PDT
We incur a noticeable amount of overhead on some benchmarks due to checking if the Watchdog ever fired. There is no reason to do this checking if we never activated the Watchdog, which can only be done through JSContextGroupSetExecutionTimeLimit or JSContextGroupClearExecutionTimeLimit. By allocating the Watchdog lazily on the VM we can avoid all of the associated overhead when we don't use these two API functions (which is true of most clients).
Attachments
Patch (16.41 KB, patch)
2014-05-20 14:02 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-05-20 14:02:34 PDT
Created attachment 231793 [details] Patch
Geoffrey Garen
Comment 2 2014-05-20 14:07:58 PDT
Comment on attachment 231793 [details] Patch r=me
WebKit Commit Bot
Comment 3 2014-05-20 15:56:19 PDT
Comment on attachment 231793 [details] Patch Clearing flags on attachment: 231793 Committed r169139: <http://trac.webkit.org/changeset/169139>
WebKit Commit Bot
Comment 4 2014-05-20 15:56:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.