Summary: | REGRESSION (r169065): Mountain Lion run-api-tests failures: ASSERTION FAILED: Uncaught exception - -[NSRegularLegacyScrollerImp setPresentationValue:]: unrecognized selector sent to instance 0x7ff51aa38000 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Component: | Tools / Tests | Assignee: | Beth Dakin <bdakin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, bdakin, simon.fraser, thorton | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2014-05-20 07:21:40 PDT
This regression occurred when run-api-tests was broken on Mountain Lion due to Bug 132954, which caused breakage starting in r169042 until it was fixed in r169078. Looks like a regression from r169065: Bug 133077: Scrollbars display incorrectly after switching between fast and slow scrolling mode, affects Find and real sites <https://bugs.webkit.org/show_bug.cgi?id=133077> <rdar://problem/16888608> <http://trac.webkit.org/changeset/169065> Beth, should the call to -setPresentationValue: not be called on Mountain Lion, or does NSRegularLegacyScrollerImp need a stub method implemented that does nothing? (In reply to comment #3) > Looks like a regression from r169065: > > Bug 133077: Scrollbars display incorrectly after switching between fast and slow scrolling mode, affects Find and real sites > <https://bugs.webkit.org/show_bug.cgi?id=133077> > <rdar://problem/16888608> > <http://trac.webkit.org/changeset/169065> > > Beth, should the call to -setPresentationValue: not be called on Mountain Lion, or does NSRegularLegacyScrollerImp need a stub method implemented that does nothing? I think we should just not call it for Mountain Lion. I can post a patch shortly. Created attachment 231779 [details]
Patch
Created attachment 231781 [details]
Patch
The other ifdef will work, but this one is better and it matches the ifdef in Scrollbar::supportsUpdateOnSecondaryThread().
Thanks Tim! http://trac.webkit.org/changeset/169124 |