| Summary: | Make fast/dom/remove-element-with-{id|name}-that-was-inserted-on-DOMNodeRemoved.html reliable | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | Tools / Tests | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, dbates, mjs, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 231728 [details]
Patch v1
Comment on attachment 231728 [details]
Patch v1
Wouldn’t we have to do this for all tests? I’m not sure this is the right solution to this problem. Can’t we fix it in DumpRenderTree instead?
Comment on attachment 231728 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=231728&action=review > LayoutTests/ChangeLog:11 > + - Use waitUntilDone()/notifyDone() to make the tests reliable on > + iOS with the WebThread enabled. I think that there is nothing special about iOS DumpRendreTree here - these tests have a setTimeout that races with parsing. They could fail on OS X as well. Committed r169111: <http://trac.webkit.org/changeset/169111> |
When running fast/dom/remove-element-with-{id|name}-that-was-inserted-on-DOMNodeRemoved.html on iOS WebKit with the WebThread, we need to make sure to wait until the second inserted script has run.