Bug 133075

Summary:

collect web timing data on iOS

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

ap, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

iOS 7.0

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	sam: review+

Alex Christensen

Reported 2014-05-19 10:40:55 PDT

I collect web timing data from CFNetwork on Mac, and we should do something similar on iOS to make the web timing data more complete.

Attachments
Patch (17.85 KB, patch) 2014-05-19 10:47 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (17.80 KB, patch) 2014-05-19 10:53 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (18.68 KB, patch) 2014-05-19 12:10 PDT, Alex Christensen	sam: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2014-05-19 10:47:10 PDT

Created attachment 231701 [details] Patch

Alex Christensen

Comment 2 2014-05-19 10:53:53 PDT

Created attachment 231702 [details] Patch

Simon Fraser (smfr)

Comment 3 2014-05-19 10:55:16 PDT

Comment on attachment 231701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231701&action=review > Source/WebCore/platform/network/ResourceHandle.h:141 > + static void getTimingData(NSDictionary *, ResourceLoadTiming&); > + static void getTimingData(CFDictionaryRef, ResourceLoadTiming&); These are a bit confusing, Why not: static void getConnectionTimingData(CFURLConnectionRef, ResourceLoadTiming&).

Alex Christensen

Comment 4 2014-05-19 10:57:53 PDT

(In reply to comment #3) > (From update of attachment 231701 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231701&action=review > > > Source/WebCore/platform/network/ResourceHandle.h:141 > > + static void getTimingData(NSDictionary *, ResourceLoadTiming&); > > + static void getTimingData(CFDictionaryRef, ResourceLoadTiming&); > > These are a bit confusing, Why not: static void getConnectionTimingData(CFURLConnectionRef, ResourceLoadTiming&). One is already used on osx, which uses a NSURLConnection from which I can get a NSDictionary*. One is going to be used with iOS which uses CFNetwork, and I can only get a CFDictionaryRef. It is a bit confusing, but that's how the data is available.

Alex Christensen

Comment 5 2014-05-19 12:10:53 PDT

Created attachment 231707 [details] Patch

Sam Weinig

Comment 6 2014-05-19 16:39:52 PDT

Comment on attachment 231707 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231707&action=review > Source/WebCore/platform/network/mac/ResourceHandleMac.mm:715 > + if (timingData) { Do an early return here.

Alex Christensen

Comment 7 2014-05-19 16:46:55 PDT

http://trac.webkit.org/changeset/169082

Note You need to log in before you can comment on or make changes to this bug.