Summary: | collect web timing data on iOS | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Enhancement | CC: | ap, simon.fraser | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | iPhone / iPad | ||||||||||
OS: | iOS 7.0 | ||||||||||
Attachments: |
|
Description
Alex Christensen
2014-05-19 10:40:55 PDT
Created attachment 231701 [details]
Patch
Created attachment 231702 [details]
Patch
Comment on attachment 231701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231701&action=review > Source/WebCore/platform/network/ResourceHandle.h:141 > + static void getTimingData(NSDictionary *, ResourceLoadTiming&); > + static void getTimingData(CFDictionaryRef, ResourceLoadTiming&); These are a bit confusing, Why not: static void getConnectionTimingData(CFURLConnectionRef, ResourceLoadTiming&). (In reply to comment #3) > (From update of attachment 231701 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231701&action=review > > > Source/WebCore/platform/network/ResourceHandle.h:141 > > + static void getTimingData(NSDictionary *, ResourceLoadTiming&); > > + static void getTimingData(CFDictionaryRef, ResourceLoadTiming&); > > These are a bit confusing, Why not: static void getConnectionTimingData(CFURLConnectionRef, ResourceLoadTiming&). One is already used on osx, which uses a NSURLConnection from which I can get a NSDictionary*. One is going to be used with iOS which uses CFNetwork, and I can only get a CFDictionaryRef. It is a bit confusing, but that's how the data is available. Created attachment 231707 [details]
Patch
Comment on attachment 231707 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231707&action=review > Source/WebCore/platform/network/mac/ResourceHandleMac.mm:715 > + if (timingData) { Do an early return here. |