Bug 133061

Summary: Use RenderStyle& in more places in RenderLayerBacking
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Description Simon Fraser (smfr) 2014-05-18 22:09:28 PDT
Use RenderStyle& in more places in RenderLayerBacking
Comment 1 Simon Fraser (smfr) 2014-05-18 22:10:51 PDT
Created attachment 231673 [details]
Patch
Comment 2 Andreas Kling 2014-05-18 23:20:15 PDT
Comment on attachment 231673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231673&action=review

r=me

> Source/WebCore/rendering/RenderLayerBacking.cpp:1519
> +    const FillLayer* fillLayer = style.backgroundLayers();

Maybe we could make RenderStyle::backgroundLayers() return a FillLayer&, too.
Then we'd get rid of even more ->'s.
Comment 3 Simon Fraser (smfr) 2014-05-19 08:49:38 PDT
(In reply to comment #2)
> (From update of attachment 231673 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231673&action=review
> 
> r=me
> 
> > Source/WebCore/rendering/RenderLayerBacking.cpp:1519
> > +    const FillLayer* fillLayer = style.backgroundLayers();
> 
> Maybe we could make RenderStyle::backgroundLayers() return a FillLayer&, too.
> Then we'd get rid of even more ->'s.

I don't think we can. It may not have any.
Comment 4 Simon Fraser (smfr) 2014-05-19 08:54:34 PDT
http://trac.webkit.org/changeset/169046