Bug 133027 – REGRESSION (r166422): All RenderBox objects grew 104 bytes from adding repaint timers.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Andreas Kling]

<rdar://problem/16867410>

[Andreas Kling]

Created attachment 231624 [details]
Patch

[Antti Koivisto]

Comment on attachment 231624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231624&action=review

> Source/WebCore/rendering/RenderBox.cpp:131
>  RenderBox::~RenderBox()
>  {
> -    m_repaintTimer.stop();
> +    view().unscheduleLazyRepaint(*this);

Shouldn't it check the lazy repaint bit? Unscheduling does hash lookup and is expensive. Also we might want to not do this on full tree teardown.

> Source/WebCore/rendering/RenderView.cpp:142
> +void RenderView::scheduleLazyRepaint(RenderBox& renderer)
> +{
> +    renderer.setRenderBoxNeedsLazyRepaint(true);

This could bail out if the bit is already set.

> Source/WebCore/rendering/RenderView.cpp:150
> +void RenderView::unscheduleLazyRepaint(RenderBox& renderer)
> +{
> +    renderer.setRenderBoxNeedsLazyRepaint(false);

This could either assert or bail out if the bit is not set.

[Andreas Kling]

Created attachment 231625 [details]
Patch

That went really well. Let's try again!

[WebKit Commit Bot]

Comment on attachment 231625 [details]
Patch

Clearing flags on attachment: 231625

Committed r168993: <http://trac.webkit.org/changeset/168993>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.