Summary: | [Phone Number Detection] drop-down menu in the phone number detection box doesn't appear | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | beidson, bfulgham, commit-queue, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Brent Fulgham
2014-05-16 21:17:49 PDT
Created attachment 231620 [details]
Patch
Comment on attachment 231620 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231620&action=review > Source/WebKit2/ChangeLog:10 > + time we call drawRect. This gets called ~9 times per screen refresh, so end up with no active ~9 times? That seems like a lot. Do we have a bug tracking why we are calling drawRect here so much? Comment on attachment 231620 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231620&action=review >> Source/WebKit2/ChangeLog:10 >> + time we call drawRect. This gets called ~9 times per screen refresh, so end up with no active > > ~9 times? That seems like a lot. Do we have a bug tracking why we are calling drawRect here so much? Once per tile. It varies by how much of the screen is dirty, and how large the screen is. I think this is working as designed.. Comment on attachment 231620 [details] Patch Clearing flags on attachment: 231620 Committed r168998: <http://trac.webkit.org/changeset/168998> All reviewed patches have been landed. Closing bug. |