Bug 133014

Summary:

[ftlopt] A StructureSet with one element should only require one word and no allocation

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, bunhere, commit-queue, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, msaboff, oliver, rakuco, sam, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

128073

Attachments:

Description	Flags
it begins	none
it compiles	none
the patch	oliver: review+

Description Filip Pizlo 2014-05-16 15:54:47 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2014-05-16 15:55:22 PDT

Created attachment 231600 [details]
it begins

Comment 2 Oliver Hunt 2014-05-16 16:19:48 PDT

Comment on attachment 231600 [details]
it begins

View in context: https://bugs.webkit.org/attachment.cgi?id=231600&action=review

> Source/JavaScriptCore/bytecode/StructureSet.h:423
> +    void set(uintptr_t pointer, bool singleStructure)

Where do we need this version? can we call it something else?

Comment 3 Filip Pizlo 2014-05-16 19:57:26 PDT

(In reply to comment #2)
> (From update of attachment 231600 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231600&action=review
> 
> > Source/JavaScriptCore/bytecode/StructureSet.h:423
> > +    void set(uintptr_t pointer, bool singleStructure)
> 
> Where do we need this version? can we call it something else?

It's used by the other set() methods.

Comment 4 Filip Pizlo 2014-05-16 20:39:05 PDT

Created attachment 231618 [details]
it compiles

Comment 5 Filip Pizlo 2014-05-16 22:00:54 PDT

Created attachment 231622 [details]
the patch

Comment 6 WebKit Commit Bot 2014-05-16 22:02:33 PDT

Attachment 231622 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/StructureSet.h:73:  The parameter name "structure" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/bytecode/StructureSet.h:74:  The parameter name "structure" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/bytecode/StructureSet.h:75:  The parameter name "structure" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/bytecode/StructureSet.h:123:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/bytecode/StructureSet.h:134:  The parameter name "structure" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/bytecode/StructureSet.h:135:  The parameter name "structure" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/bytecode/StructureSet.h:141:  The parameter name "list" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 7 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 Filip Pizlo 2014-05-16 22:39:05 PDT

(In reply to comment #6)
> Attachment 231622 [details] did not pass style-queue:
> 
> 
> ERROR: Source/JavaScriptCore/bytecode/StructureSet.h:73:  The parameter name "structure" adds no information, so it should be removed.  [readability/parameter_name] [5]
> ERROR: Source/JavaScriptCore/bytecode/StructureSet.h:74:  The parameter name "structure" adds no information, so it should be removed.  [readability/parameter_name] [5]
> ERROR: Source/JavaScriptCore/bytecode/StructureSet.h:75:  The parameter name "structure" adds no information, so it should be removed.  [readability/parameter_name] [5]
> ERROR: Source/JavaScriptCore/bytecode/StructureSet.h:123:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
> ERROR: Source/JavaScriptCore/bytecode/StructureSet.h:134:  The parameter name "structure" adds no information, so it should be removed.  [readability/parameter_name] [5]
> ERROR: Source/JavaScriptCore/bytecode/StructureSet.h:135:  The parameter name "structure" adds no information, so it should be removed.  [readability/parameter_name] [5]
> ERROR: Source/JavaScriptCore/bytecode/StructureSet.h:141:  The parameter name "list" adds no information, so it should be removed.  [readability/parameter_name] [5]
> Total errors found: 7 in 11 files

Fixed!

> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 8 Filip Pizlo 2014-05-20 22:17:46 PDT

Landed in http://trac.webkit.org/changeset/169148