Summary: | [GTK][EFL] Build break after 168978 | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Piotr Grad <piotr.grad> | ||||||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ap, berto, buildbot, bunhere, cdumez, cgarcia, commit-queue, gustavo, gyuyoung.kim, mrobinson, ossy, rniwa, sergio | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 133006 | ||||||||||||
Attachments: |
|
Description
Piotr Grad
2014-05-16 14:42:10 PDT
Created attachment 231593 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Created attachment 231594 [details]
Patch
Created attachment 231597 [details]
Patch for efl
Comment on attachment 231597 [details] Patch for efl Attachment 231597 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5215022355578880 New failing tests: editing/unsupported-content/list-type-before.html editing/unsupported-content/table-type-before.html editing/unsupported-content/table-delete-002.html editing/unsupported-content/list-delete-001.html editing/unsupported-content/list-type-after.html editing/unsupported-content/list-delete-003.html editing/unsupported-content/table-type-after.html Created attachment 231607 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 231594 [details] Patch Clearing flags on attachment: 231594 Committed r168988: <http://trac.webkit.org/changeset/168988> Comment on attachment 231597 [details] Patch for efl Clearing flags on attachment: 231597 Committed r168992: <http://trac.webkit.org/changeset/168992> All reviewed patches have been landed. Closing bug. Please don't upload two different patch to one bug report next time. There is a de-facto rule in WebKit: one bug report / one patch. Otherwise GTK and EFL buildfixes could have been done in one patch. ;) Additionally please add the original bug to the blocks list and/or add a comment to the original bug with reference to this bug. We can easily avoid parallel works on same things. ( Now I saw the broken EFL bots. I checked the original bug and the pending reviews and haven't found any work on it. And then I started to fix the build. But I noticed your fix landed. ) |