Bug 133012 - [GTK][EFL] Build break after 168978
Summary: [GTK][EFL] Build break after 168978
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 133006
  Show dependency treegraph
Reported: 2014-05-16 14:42 PDT by Piotr Grad
Modified: 2014-05-16 23:48 PDT (History)
13 users (show)

See Also:

Patch (1.49 KB, patch)
2014-05-16 14:51 PDT, Piotr Grad
no flags Details | Formatted Diff | Diff
Patch (1.35 KB, patch)
2014-05-16 14:56 PDT, Piotr Grad
no flags Details | Formatted Diff | Diff
Patch for efl (1.22 KB, patch)
2014-05-16 15:09 PDT, Piotr Grad
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (1.27 MB, application/zip)
2014-05-16 18:09 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Grad 2014-05-16 14:42:10 PDT
Build break after 168978
Comment 1 Piotr Grad 2014-05-16 14:51:24 PDT
Created attachment 231593 [details]
Comment 2 WebKit Commit Bot 2014-05-16 14:53:31 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Piotr Grad 2014-05-16 14:56:52 PDT
Created attachment 231594 [details]
Comment 4 Piotr Grad 2014-05-16 15:09:23 PDT
Created attachment 231597 [details]
Patch for efl
Comment 5 Build Bot 2014-05-16 18:08:58 PDT
Comment on attachment 231597 [details]
Patch for efl

Attachment 231597 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5215022355578880

New failing tests:
Comment 6 Build Bot 2014-05-16 18:09:07 PDT
Created attachment 231607 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 7 WebKit Commit Bot 2014-05-16 18:37:31 PDT
Comment on attachment 231594 [details]

Clearing flags on attachment: 231594

Committed r168988: <http://trac.webkit.org/changeset/168988>
Comment 8 WebKit Commit Bot 2014-05-16 23:24:16 PDT
Comment on attachment 231597 [details]
Patch for efl

Clearing flags on attachment: 231597

Committed r168992: <http://trac.webkit.org/changeset/168992>
Comment 9 WebKit Commit Bot 2014-05-16 23:24:23 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Csaba Osztrogonác 2014-05-16 23:48:04 PDT
Please don't upload two different patch to one bug report next time.
There is a de-facto rule in WebKit: one bug report / one patch.
Otherwise GTK and EFL buildfixes could have been done in one patch. ;)

Additionally please add the original bug to the blocks list
and/or add a comment to the original bug with reference to
this bug. We can easily avoid parallel works on same things.

( Now I saw the broken EFL bots. I checked the original bug and the
pending reviews and haven't found any work on it. And then I started 
to fix the build. But I noticed your fix landed. )