RESOLVED FIXED133012
[GTK][EFL] Build break after 168978 
https://bugs.webkit.org/show_bug.cgi?id=133012
Summary [GTK][EFL] Build break after 168978
Piotr Grad
Reported 2014-05-16 14:42:10 PDT
Build break after 168978
Attachments
Patch (1.49 KB, patch)
2014-05-16 14:51 PDT, Piotr Grad 		no flags
DetailsFormatted DiffDiff
Patch (1.35 KB, patch)
2014-05-16 14:56 PDT, Piotr Grad 		no flags
DetailsFormatted DiffDiff
Patch for efl (1.22 KB, patch)
2014-05-16 15:09 PDT, Piotr Grad 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (1.27 MB, application/zip)
2014-05-16 18:09 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Piotr Grad
Comment 1 2014-05-16 14:51:24 PDT
Created attachment 231593 [details] Patch
WebKit Commit Bot
Comment 2 2014-05-16 14:53:31 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Piotr Grad
Comment 3 2014-05-16 14:56:52 PDT
Created attachment 231594 [details] Patch
Piotr Grad
Comment 4 2014-05-16 15:09:23 PDT
Created attachment 231597 [details] Patch for efl
Build Bot
Comment 5 2014-05-16 18:08:58 PDT
Comment on attachment 231597 [details] Patch for efl Attachment 231597 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5215022355578880 New failing tests: editing/unsupported-content/list-type-before.html editing/unsupported-content/table-type-before.html editing/unsupported-content/table-delete-002.html editing/unsupported-content/list-delete-001.html editing/unsupported-content/list-type-after.html editing/unsupported-content/list-delete-003.html editing/unsupported-content/table-type-after.html
Build Bot
Comment 6 2014-05-16 18:09:07 PDT
Created attachment 231607 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
WebKit Commit Bot
Comment 7 2014-05-16 18:37:31 PDT
Comment on attachment 231594 [details] Patch Clearing flags on attachment: 231594 Committed r168988: <http://trac.webkit.org/changeset/168988>
WebKit Commit Bot
Comment 8 2014-05-16 23:24:16 PDT
Comment on attachment 231597 [details] Patch for efl Clearing flags on attachment: 231597 Committed r168992: <http://trac.webkit.org/changeset/168992>
WebKit Commit Bot
Comment 9 2014-05-16 23:24:23 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 10 2014-05-16 23:48:04 PDT
Please don't upload two different patch to one bug report next time. There is a de-facto rule in WebKit: one bug report / one patch. Otherwise GTK and EFL buildfixes could have been done in one patch. ;) Additionally please add the original bug to the blocks list and/or add a comment to the original bug with reference to this bug. We can easily avoid parallel works on same things. ( Now I saw the broken EFL bots. I checked the original bug and the pending reviews and haven't found any work on it. And then I started to fix the build. But I noticed your fix landed. )
Note You need to log in before you can comment on or make changes to this bug.