| Summary: | [Mac] naturalSize not updated when preload=metadata | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ahmad.saleem792, commit-queue, eric.carlson, glenn, philipj, sergio, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jer Noble
2014-05-16 11:48:43 PDT
Created attachment 231582 [details]
Patch
Comment on attachment 231582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231582&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1485 > + if (AVAssetTrack* firstVideoTrack = [videoTracks firstObject]) > + presentationSizeDidChange(IntSize(CGSizeApplyAffineTransform([firstVideoTrack naturalSize], [firstVideoTrack preferredTransform]))); > + else > + presentationSizeDidChange(IntSize()); This won't be correct if the first video track isn't enabled. Created attachment 231584 [details]
Patch for landing.
Created attachment 231586 [details]
Patch for landing.
Attachment 231586 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1459: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 231586 [details] Patch for landing. Clearing flags on attachment: 231586 Committed r168979: <http://trac.webkit.org/changeset/168979> Seems it landed but not got reverted (checked on GitHub with bug ID). |