old-run-webkit-tests: allow specifying a simulator app path

• Component: Tools / Tests
• Status: RESOLVED FIXED

[David Farler]

Since the iOS simulator app bundle may not already be registered with launch services (multiple relocatable Xcode.app bundles may exist on the machine), provide a command line parameter to specify exactly where the simulator app is for the first launch.

[David Farler]

Created attachment 231544 [details]
Patch

[David Kilzer (:ddkilzer)]

Comment on attachment 231544 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231544&action=review

r=me, but consider providing a more specific default as well based on $SDKROOT.

> Tools/Scripts/old-run-webkit-tests:191
> +my $simulatorApp = 'iOS Simulator';

Instead of specifying a command-line argument, why not just construct the path based on the $SDKROOT path?

It's always installed at a well-known location, so we should be able to construct the path using the $SDKROOT.

I'm surprised there isn't a way to find it using 'xcrun -sdk iphonesimulator', but maybe that's only for command-line executables.

[David Farler]

Roger. I guess it would be better to do something like the following, which should provide an accurate default. I guess most people aren't switching between Xcode.app bundles on an hourly basis :).

chomp(my $developerDir = $ENV{DEVELOPER_DIR} || `xcode-select --print-path`);
my $simulatorApp = "$developerDir/Applications/iOS Simulator.app";
unless (-d $simulatorApp) {
    $simulatorApp = "$developerDir/Applications/iPhone Simulator.app";
}

[David Farler]

Created attachment 231574 [details]
Patch

[David Farler]

Committed r168969: <http://trac.webkit.org/changeset/168969>