Bug 132959 – TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac

• Component: Tools / Tests
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

Add a Tools/TestWebKitAPI/Tests/cocoa directory and move URLExtras.mm into it.

This will make the test runnable on the iOS Simulator once Bug 129535 lands to add iOS support to run-api-tests.

There is much more to do in this space, but this is a start.

[David Kilzer (:ddkilzer)]

Created attachment 231522 [details]
Patch v1

Comment on attachment 231522 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=231522&action=review

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:963
> +				44A82E7B19251B3500C1C8C4 /* cocoa */,

I know that we have all-lowercase mac group and directory, but in the WebKit2 project and in Source/WebKit2 we’ve been capitalizing but the Cocoa groups in the project and the Cocoa directories.

[David Kilzer (:ddkilzer)]

(In reply to comment #2)
> (From update of attachment 231522 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231522&action=review
> 
> > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:963
> > +				44A82E7B19251B3500C1C8C4 /* cocoa */,
> 
> I know that we have all-lowercase mac group and directory, but in the WebKit2 project and in Source/WebKit2 we’ve been capitalizing but the Cocoa groups in the project and the Cocoa directories.

Okay, will change to Cocoa.  Thanks!

[David Kilzer (:ddkilzer)]

Committed r168900: <http://trac.webkit.org/changeset/168900>