Bug 132959

Summary: TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ap, darin, mitz, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 mitz: review+

Description David Kilzer (:ddkilzer) 2014-05-15 09:09:40 PDT 
Add a Tools/TestWebKitAPI/Tests/cocoa directory and move URLExtras.mm into it.

This will make the test runnable on the iOS Simulator once Bug 129535 lands to add iOS support to run-api-tests.

There is much more to do in this space, but this is a start.
Comment 1 David Kilzer (:ddkilzer) 2014-05-15 09:14:00 PDT 
Created attachment 231522 [details]
Patch v1
Comment 2 mitz 2014-05-15 09:20:25 PDT 
Comment on attachment 231522 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=231522&action=review

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:963
> +				44A82E7B19251B3500C1C8C4 /* cocoa */,

I know that we have all-lowercase mac group and directory, but in the WebKit2 project and in Source/WebKit2 we’ve been capitalizing but the Cocoa groups in the project and the Cocoa directories.
Comment 3 David Kilzer (:ddkilzer) 2014-05-15 10:09:50 PDT 
(In reply to comment #2)
> (From update of attachment 231522 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231522&action=review
> 
> > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:963
> > +				44A82E7B19251B3500C1C8C4 /* cocoa */,
> 
> I know that we have all-lowercase mac group and directory, but in the WebKit2 project and in Source/WebKit2 we’ve been capitalizing but the Cocoa groups in the project and the Cocoa directories.

Okay, will change to Cocoa.  Thanks!
Comment 4 David Kilzer (:ddkilzer) 2014-05-15 10:19:18 PDT 
Committed r168900: <http://trac.webkit.org/changeset/168900>