Bug 132943

Summary: [UI-side compositing] Fix copying animations between layers, and pausing them
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
For EWS none

Simon Fraser (smfr)
Reported 2014-05-14 22:25:30 PDT
[UI-side compositing] Fix copying animations between layers, and pausing them
Attachments
Patch (27.95 KB, patch)
2014-05-14 22:32 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
For EWS (28.80 KB, patch)
2014-05-15 09:37 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-05-14 22:32:43 PDT
Created attachment 231492 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-05-14 22:34:39 PDT
*** Bug 132894 has been marked as a duplicate of this bug. ***
Simon Fraser (smfr)
Comment 3 2014-05-14 22:35:59 PDT
Patch applies on top of that in bug 132942.
Tim Horton
Comment 4 2014-05-14 23:35:31 PDT
Comment on attachment 231492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231492&action=review > Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.h:36 > OBJC_CLASS WKAnimationDelegate; > +OBJC_CLASS CAAnimation; sorting > Source/WebKit2/WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:124 > + void didStart(CFTimeInterval beginTime) one line? > Source/WebKit2/WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:130 > + void setHasExplicitBeginTime(bool b) { m_properties.hasExplicitBeginTime = b; } b :| > Source/WebKit2/WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:297 > + // Copy the specific Basic or Keyframe values period > Source/WebKit2/WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:763 > + [caAnimation.get() setValue:@YES forKey:WKExplicitBeginTimeFlag]; no .get()
Simon Fraser (smfr)
Comment 5 2014-05-15 09:37:44 PDT
Created attachment 231524 [details] For EWS
Simon Fraser (smfr)
Comment 6 2014-05-15 10:50:24 PDT
http://trac.webkit.org/changeset/168901
Note You need to log in before you can comment on or make changes to this bug.