| Summary: | [UI-side compositing] Fix copying animations between layers, and pausing them | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dino, simon.fraser, thorton | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2014-05-14 22:25:30 PDT
Created attachment 231492 [details]
Patch
*** Bug 132894 has been marked as a duplicate of this bug. *** Patch applies on top of that in bug 132942. Comment on attachment 231492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231492&action=review > Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.h:36 > OBJC_CLASS WKAnimationDelegate; > +OBJC_CLASS CAAnimation; sorting > Source/WebKit2/WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:124 > + void didStart(CFTimeInterval beginTime) one line? > Source/WebKit2/WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:130 > + void setHasExplicitBeginTime(bool b) { m_properties.hasExplicitBeginTime = b; } b :| > Source/WebKit2/WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:297 > + // Copy the specific Basic or Keyframe values period > Source/WebKit2/WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:763 > + [caAnimation.get() setValue:@YES forKey:WKExplicitBeginTimeFlag]; no .get() Created attachment 231524 [details]
For EWS
|