Bug 132943 - [UI-side compositing] Fix copying animations between layers, and pausing them
Summary: [UI-side compositing] Fix copying animations between layers, and pausing them
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
: 132894 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-05-14 22:25 PDT by Simon Fraser (smfr)
Modified: 2014-05-15 10:50 PDT (History)
3 users (show)

See Also:

Attachments
Patch (27.95 KB, patch)
2014-05-14 22:32 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
For EWS (28.80 KB, patch)
2014-05-15 09:37 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-05-14 22:25:30 PDT 
[UI-side compositing] Fix copying animations between layers, and pausing them
Comment 1 Simon Fraser (smfr) 2014-05-14 22:32:43 PDT 
Created attachment 231492 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-05-14 22:34:39 PDT 
*** Bug 132894 has been marked as a duplicate of this bug. ***
Comment 3 Simon Fraser (smfr) 2014-05-14 22:35:59 PDT 
Patch applies on top of that in bug 132942.
Comment 4 Tim Horton 2014-05-14 23:35:31 PDT 
Comment on attachment 231492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231492&action=review

> Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.h:36
>  OBJC_CLASS WKAnimationDelegate;
> +OBJC_CLASS CAAnimation;

sorting

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:124
> +    void didStart(CFTimeInterval beginTime)

one line?

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:130
> +    void setHasExplicitBeginTime(bool b) { m_properties.hasExplicitBeginTime = b; }

b :|

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:297
> +    // Copy the specific Basic or Keyframe values

period

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:763
> +        [caAnimation.get() setValue:@YES forKey:WKExplicitBeginTimeFlag];

no .get()
Comment 5 Simon Fraser (smfr) 2014-05-15 09:37:44 PDT 
Created attachment 231524 [details]
For EWS
Comment 6 Simon Fraser (smfr) 2014-05-15 10:50:24 PDT 
http://trac.webkit.org/changeset/168901