Bug 132936

Summary: [EFL][WK2] Use default context for ewk_view_add
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, hyuki.kim, lucas.de.marchi, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2014-05-14 20:33:32 PDT
It's regression of r146265.
Attachments
Patch (1.53 KB, patch)
2014-05-14 20:43 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (2.36 KB, patch)
2014-05-14 20:55 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2014-05-14 20:43:25 PDT
Created attachment 231485 [details] Patch
Ryuan Choi
Comment 2 2014-05-14 20:55:41 PDT
Created attachment 231487 [details] Patch
Jinwoo Song
Comment 3 2014-05-14 21:03:31 PDT
Comment on attachment 231487 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231487&action=review > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:254 > + ASSERT_EQ(ewk_view_context_get(view), ewk_context_default_get()); You have to change the parameter order because ewk_context_default_get() is the expected result in this case.
Ryuan Choi
Comment 4 2014-05-14 21:21:29 PDT
Committed r168891: <http://trac.webkit.org/changeset/168891>
Ryuan Choi
Comment 5 2014-05-14 21:33:19 PDT
Comment on attachment 231487 [details] Patch thanks, fixed and landed.
Note You need to log in before you can comment on or make changes to this bug.