Bug 132918

Summary: JSDOMWindow should not claim HasImpureGetOwnPropertySlot
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 132705    
Attachments:
Description Flags
Patch none

Mark Hahnenberg
Reported 2014-05-14 11:51:54 PDT
We now correctly handle the impurity of JSDOMWindow's custom getOwnPropertySlot without needing the blanket HasImpureGetOwnPropertySlot. Getting rid of this flag will allow us to cache many properties/methods on both the JSDOMWindow and its prototype, which are very commonly used across the web.
Attachments
Patch (10.33 KB, patch)
2014-05-15 15:30 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-05-15 15:30:08 PDT
Created attachment 231536 [details] Patch
Geoffrey Garen
Comment 2 2014-05-15 15:49:53 PDT
Comment on attachment 231536 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231536&action=review r=me > Source/WebCore/ChangeLog:12 > + We now correctly handle the impurity of JSDOMWindow's custom getOwnPropertySlot without needing the > + blanket HasImpureGetOwnPropertySlot. Getting rid of this flag will allow us to cache many Should specify that we do this through explicit watchpoint.
Mark Hahnenberg
Comment 3 2014-05-15 16:03:38 PDT
Committed r168914: <http://trac.webkit.org/changeset/168914>
Mark Hahnenberg
Comment 4 2014-05-15 16:04:21 PDT
Comment on attachment 231536 [details] Patch Clearing review flag.
Note You need to log in before you can comment on or make changes to this bug.