Bug 132912

Summary: Implement NSSharingServiceDelegate method "transitionImageForShareItem"
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, thorton, zalan
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch v1
thorton: review+
Patch v2 - Review feedback, build fix, and add "paint selection only" mode as discussed on IRC. thorton: review+

Brady Eidson
Reported 2014-05-14 09:50:05 PDT
Implement NSSharingServiceDelegate method "transitionImageForShareItem" <rdar://problem/16878020>
Attachments
Patch v1 (7.46 KB, patch)
2014-05-14 11:44 PDT, Brady Eidson 		thorton: review+
DetailsFormatted DiffDiff
Patch v2 - Review feedback, build fix, and add "paint selection only" mode as discussed on IRC. (8.38 KB, patch)
2014-05-14 12:36 PDT, Brady Eidson 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2014-05-14 11:44:46 PDT
Created attachment 231461 [details] Patch v1
Tim Horton
Comment 2 2014-05-14 11:52:29 PDT
Comment on attachment 231461 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=231461&action=review > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:443 > + buffer->context()->translate(-FloatSize(rect.x(), rect.y())); -toFloatSize(rect.location()) > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:444 > + frameView->paintContents(buffer->context(), IntRect(rect)); is this truncated FloatRect->IntRect right?
Brady Eidson
Comment 3 2014-05-14 12:36:50 PDT
Created attachment 231462 [details] Patch v2 - Review feedback, build fix, and add "paint selection only" mode as discussed on IRC.
Brady Eidson
Comment 4 2014-05-14 13:12:52 PDT
http://trac.webkit.org/changeset/168859
Note You need to log in before you can comment on or make changes to this bug.