Bug 132912

Summary: Implement NSSharingServiceDelegate method "transitionImageForShareItem"
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, thorton, zalan
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch v1
thorton: review+
Patch v2 - Review feedback, build fix, and add "paint selection only" mode as discussed on IRC. thorton: review+

Description Brady Eidson 2014-05-14 09:50:05 PDT
Implement NSSharingServiceDelegate method "transitionImageForShareItem"

<rdar://problem/16878020>
Comment 1 Brady Eidson 2014-05-14 11:44:46 PDT
Created attachment 231461 [details]
Patch v1
Comment 2 Tim Horton 2014-05-14 11:52:29 PDT
Comment on attachment 231461 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=231461&action=review

> Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:443
> +    buffer->context()->translate(-FloatSize(rect.x(), rect.y()));

-toFloatSize(rect.location())

> Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:444
> +    frameView->paintContents(buffer->context(), IntRect(rect));

is this truncated FloatRect->IntRect right?
Comment 3 Brady Eidson 2014-05-14 12:36:50 PDT
Created attachment 231462 [details]
Patch v2 - Review feedback, build fix, and add "paint selection only" mode as discussed on IRC.
Comment 4 Brady Eidson 2014-05-14 13:12:52 PDT
http://trac.webkit.org/changeset/168859