Summary: | Implement NSSharingServiceDelegate method "transitionImageForShareItem" | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||
Component: | WebKit Misc. | Assignee: | Brady Eidson <beidson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | simon.fraser, thorton, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Brady Eidson
2014-05-14 09:50:05 PDT
Created attachment 231461 [details]
Patch v1
Comment on attachment 231461 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=231461&action=review > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:443 > + buffer->context()->translate(-FloatSize(rect.x(), rect.y())); -toFloatSize(rect.location()) > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:444 > + frameView->paintContents(buffer->context(), IntRect(rect)); is this truncated FloatRect->IntRect right? Created attachment 231462 [details]
Patch v2 - Review feedback, build fix, and add "paint selection only" mode as discussed on IRC.
|