Bug 132900

Summary:

GIF animations don't restart after scrolling on iOS WebKit1

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	kling: review+

Description Antti Koivisto 2014-05-14 02:28:00 PDT

a bug

Comment 1 Antti Koivisto 2014-05-14 02:33:59 PDT

Created attachment 231438 [details]
patch

Comment 2 Andreas Kling 2014-05-14 02:37:18 PDT

Comment on attachment 231438 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231438&action=review

OK

> Source/WebKit/mac/WebView/WebView.mm:1581
> +    FrameView* view = [self _mainCoreFrame]->view();

I think "FrameView *view" is the appropriate style here.

Comment 3 Antti Koivisto 2014-05-14 02:49:24 PDT

http://trac.webkit.org/changeset/168830

Comment 4 Darin Adler 2014-05-14 09:24:24 PDT

Comment on attachment 231438 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231438&action=review

>> Source/WebKit/mac/WebView/WebView.mm:1581
>> +    FrameView* view = [self _mainCoreFrame]->view();
> 
> I think "FrameView *view" is the appropriate style here.

No, the style is right. We do that different formatting thing with * only for Objective-C types, not for C++ types like FrameView.

We should probably change the rule though. The only place where we need the "X *" style is in public Objective-C headers. Inside the code it would be easier if we adopted a consistent rule.