Bug 132897

Summary: Use INT_MAX instead of UINT_MAX to indicate end-of-segment
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: NEW    
Severity: Normal CC: andersca, dino, jonlee, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Not for review none

Myles C. Maxfield
Reported 2014-05-13 20:50:15 PDT
Use INT_MAX instead of UINT_MAX to indicate end-of-segment
Attachments
Patch (5.58 KB, patch)
2014-05-13 20:53 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Not for review (5.77 KB, patch)
2014-05-16 19:30 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-05-13 20:52:51 PDT
<rdar://problem/16492909>
Myles C. Maxfield
Comment 2 2014-05-13 20:53:41 PDT
Created attachment 231430 [details] Patch
Geoffrey Garen
Comment 3 2014-05-13 22:50:23 PDT
Comment on attachment 231430 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231430&action=review > Source/WebCore/ChangeLog:16 > + No new tests. Why not?
Anders Carlsson
Comment 4 2014-05-14 06:24:58 PDT
I think this should use std::numeric_limits<int>::max() instead of INT_MAX.
Maciej Stachowiak
Comment 5 2014-05-15 17:42:12 PDT
Comment on attachment 231430 [details] Patch I think it would be good to have a test that would have triggered the asserts or crashed. But also: I don't see any asserts in the patch. Is that a bug in the patch or the ChangeLog? r- for lack of test and for incorrect ChangeLog. Also please see andersca's comment.
Myles C. Maxfield
Comment 6 2014-05-16 19:30:48 PDT
Created attachment 231617 [details] Not for review
Note You need to log in before you can comment on or make changes to this bug.