Bug 132896

Summary:

[ftlopt] DFG should not exit due to inadequate profiling coverage when it can trivially fill in the profiling coverage due to variable constant inference and the better prediction modeling of typed array GetByVals

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	ggaren: review+

Description Filip Pizlo 2014-05-13 19:39:08 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2014-05-13 19:42:40 PDT

Created attachment 231427 [details]
the patch

Comment 2 Geoffrey Garen 2014-05-13 20:10:29 PDT

Comment on attachment 231427 [details]
the patch

Do we need a js/regress test?

Comment 3 Filip Pizlo 2014-05-13 20:11:36 PDT

(In reply to comment #2)
> (From update of attachment 231427 [details])
> Do we need a js/regress test?

I don't think so - this already gets a nice SunSpider win.  It's hard to test convergence with a synthetic benchmark, since for very small programs, even if we recompile a few times it ends up being cheap.

Comment 4 Filip Pizlo 2014-05-13 21:30:33 PDT

Landed in http://trac.webkit.org/changeset/168780