Bug 132896 - [ftlopt] DFG should not exit due to inadequate profiling coverage when it can trivially fill in the profiling coverage due to variable constant inference and the better prediction modeling of typed array GetByVals
Summary: [ftlopt] DFG should not exit due to inadequate profiling coverage when it can...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-13 19:39 PDT by Filip Pizlo
Modified: 2014-05-13 21:30 PDT (History)
7 users (show)

See Also:

Attachments
the patch (6.95 KB, patch)
2014-05-13 19:42 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-05-13 19:39:08 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2014-05-13 19:42:40 PDT 
Created attachment 231427 [details]
the patch
Comment 2 Geoffrey Garen 2014-05-13 20:10:29 PDT 
Comment on attachment 231427 [details]
the patch

Do we need a js/regress test?
Comment 3 Filip Pizlo 2014-05-13 20:11:36 PDT 
(In reply to comment #2)
> (From update of attachment 231427 [details])
> Do we need a js/regress test?

I don't think so - this already gets a nice SunSpider win.  It's hard to test convergence with a synthetic benchmark, since for very small programs, even if we recompile a few times it ends up being cheap.
Comment 4 Filip Pizlo 2014-05-13 21:30:33 PDT 
Landed in http://trac.webkit.org/changeset/168780