Bug 132894

Summary: [UI-side compositing] Scrolling breaks on news.google.com on iOS
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: simon.fraser, thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
For EWS
none
EWS again none

Description Simon Fraser (smfr) 2014-05-13 18:36:00 PDT 
[UI-side compositing] Scrolling breaks on news.google.com on iOS
Comment 1 Simon Fraser (smfr) 2014-05-13 18:38:57 PDT 
Created attachment 231425 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-05-13 18:39:14 PDT 
<rdar://problem/16887057>
Comment 3 Tim Horton 2014-05-13 18:40:29 PDT 
Comment on attachment 231425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231425&action=review

> Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:427
> +    return [m_layer.get() animationForKey:key];

no .get()
Comment 4 Simon Fraser (smfr) 2014-05-13 18:49:46 PDT 
Created attachment 231426 [details]
For EWS
Comment 5 Simon Fraser (smfr) 2014-05-13 20:32:06 PDT 
Created attachment 231429 [details]
EWS again
Comment 6 Darin Adler 2014-05-13 22:28:48 PDT 
Comment on attachment 231429 [details]
EWS again

Windows EWS error is:

     1>..\platform\graphics\ca\win\PlatformCALayerWin.cpp(313): error C2440: 'initializing' : cannot convert from 'WTF::HashTableConstIteratorAdapter<WTF::HashTable<WTF::String,WTF::KeyValuePair<WTF::String,WTF::RefPtr<WebCore::PlatformCAAnimation>>,WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String,WTF::RefPtr<WebCore::PlatformCAAnimation>>>,WTF::StringHash,WTF::HashMap<WTF::String,WTF::RefPtr<WebCore::PlatformCAAnimation>,WTF::DefaultHash<WTF::String>::Hash,WTF::HashTraits<WTF::String>,WTF::HashTraits<MappedArg>>::KeyValuePairTraits,WTF::HashTraits<WTF::String>>,WTF::KeyValuePair<WTF::String,WTF::RefPtr<WebCore::PlatformCAAnimation>>>' to 'WTF::HashTableIteratorAdapter<WTF::HashTable<WTF::String,WTF::KeyValuePair<WTF::String,WTF::RefPtr<WebCore::PlatformCAAnimation>>,WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String,WTF::RefPtr<WebCore::PlatformCAAnimation>>>,WTF::StringHash,WTF::HashMap<WTF::String,WTF::RefPtr<WebCore::PlatformCAAnimation>,WTF::DefaultHash<WTF::String>::Hash,WTF::HashTraits<WTF::String>,WTF::HashTraits<MappedArg>>::KeyValuePairTraits,WTF::HashTraits<WTF::String>>,WTF::KeyValuePair<WTF::String,WTF::RefPtr<WebCore::PlatformCAAnimation>>>'
Comment 7 Simon Fraser (smfr) 2014-05-13 22:30:05 PDT 
Comment on attachment 231429 [details]
EWS again

Thanks. This doesn't need review, I'm just EWSing.
Comment 8 Simon Fraser (smfr) 2014-05-14 22:34:39 PDT 
Bug 132943 has a better fix.

*** This bug has been marked as a duplicate of bug 132943 ***