| Summary: | REGRESSION(WK2): Many pages have very wrong text size after rotating | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Enrica Casucci <enrica> | ||||
| Component: | WebKit2 | Assignee: | Enrica Casucci <enrica> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | Keywords: | InRadar | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Enrica Casucci
2014-05-13 17:23:01 PDT
Created attachment 231423 [details]
Patch
Comment on attachment 231423 [details]
Patch
lgtm
Comment on attachment 231423 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231423&action=review Sure would be nice to have some kind of bottleneck function rather than having a width check in three different places. > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1910 > + for (Frame* frame = &m_page->mainFrame(); frame; frame = frame->tree().traverseNext(&m_page->mainFrame())) { This should just call traverseNext() with no arguments. There’s no reason to pass the main frame explicitly since there are no additional frames outside the main frame. Thanks for the feedback. I've removed the parameter to traverseNext and changed resetTextAutosizingBeforeLayout to resetTextAutosizingBeforeLayoutIfNeeded which takes p;d and new size. This way the width check is inside the new method. Committed revision 168848. |