Bug 132891

Summary: Web Inspector: Force developerExtrasEnabled when a remote client connects
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Timothy Hatcher 2014-05-13 16:30:41 PDT 
iOS does this currently in PageDebuggable. We need to do it on Mac too.

<rdar://problem/16332868>
Comment 1 Timothy Hatcher 2014-05-13 16:34:39 PDT 
Created attachment 231418 [details]
Patch
Comment 2 Joseph Pecoraro 2014-05-13 16:46:13 PDT 
Comment on attachment 231418 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231418&action=review

r=me, Ultimately we should have our own way of forcing a setting on WebCore::Settings from inside of WebCore that don't adjust the exact same bit as WebKit APIs.

> Source/WebCore/page/PageDebuggable.cpp:103
> +    if (m_forcedDeveloperExtrasEnabled)
> +        m_page.settings().setDeveloperExtrasEnabled(false);

This should now flip m_forcedDeveloperExtrasEnabled back to false.
Comment 3 Timothy Hatcher 2014-05-13 16:49:14 PDT 
Created attachment 231422 [details]
Patch
Comment 4 WebKit Commit Bot 2014-05-13 17:22:09 PDT 
Comment on attachment 231422 [details]
Patch

Clearing flags on attachment: 231422

Committed r168764: <http://trac.webkit.org/changeset/168764>
Comment 5 WebKit Commit Bot 2014-05-13 17:22:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Joseph Pecoraro 2014-05-13 18:01:42 PDT 
Build Fix: <http://trac.webkit.org/changeset/168767>