Bug 132889

Summary:

REGRESSION (topContentInset): Searching through Facebook Messenger's chat causes scrolling in News Feed

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, esprehn+autocc, glenn, kondapallykalyan, sam, simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Beth Dakin 2014-05-13 15:19:09 PDT

REGRESSION (topContentInset): Searching through Facebook Messenger's chat causes scrolling in News Feed

<rdar://problem/16715716>

Comment 1 Beth Dakin 2014-05-13 15:33:56 PDT

Created attachment 231412 [details]
Patch

Comment 2 Simon Fraser (smfr) 2014-05-13 15:37:11 PDT

Comment on attachment 231412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231412&action=review

> Source/WebCore/platform/ScrollView.cpp:430
> +    IntSize scrollOffset = this->scrollOffset();
> +    return IntSize(scrollOffset.width(), scrollOffset.height() - headerHeight());

return scrollOffset() - IntSize(0, headerHeight) ?

> Source/WebCore/platform/ScrollView.h:244
> +    // scrollOffset() anchors its (0,0) point at the top end of the scolling layer. When the Page

Seems odd for a comment in ScrollView.h to be talking about layers, since this is below the level of layer stuff. "at the top end" is odd too.

Comment 3 Beth Dakin 2014-05-13 17:14:58 PDT

Thanks Simon! http://trac.webkit.org/changeset/168763