Bug 132882

Summary: JIT breakpoints should be more informative
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 132903    
Bug Blocks:    
Attachments:
Description Flags
the patch
oliver: review+
a version that builds
none
try again! none

Filip Pizlo
Reported 2014-05-13 12:51:25 PDT
Patch forthcoming.
Attachments
the patch (44.59 KB, patch)
2014-05-13 12:53 PDT, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
a version that builds (44.11 KB, patch)
2014-05-13 15:11 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
try again! (44.15 KB, patch)
2014-05-13 16:32 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-05-13 12:53:52 PDT
Created attachment 231402 [details] the patch
Oliver Hunt
Comment 2 2014-05-13 12:57:56 PDT
Comment on attachment 231402 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=231402&action=review > Source/JavaScriptCore/assembler/MacroAssembler.h:200 > - > + drop this :D
Filip Pizlo
Comment 3 2014-05-13 13:35:02 PDT
(In reply to comment #2) > (From update of attachment 231402 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231402&action=review > > > Source/JavaScriptCore/assembler/MacroAssembler.h:200 > > - > > + > > drop this :D Fixed, thanks!
Filip Pizlo
Comment 4 2014-05-13 15:11:34 PDT
Created attachment 231410 [details] a version that builds
Filip Pizlo
Comment 5 2014-05-13 16:32:05 PDT
Created attachment 231417 [details] try again!
Filip Pizlo
Comment 6 2014-05-13 20:58:01 PDT
Landed in http://trac.webkit.org/changeset/168776
Note You need to log in before you can comment on or make changes to this bug.