Bug 132882

Summary: JIT breakpoints should be more informative
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 132903    
Bug Blocks:    
Attachments:
Description Flags
the patch
oliver: review+
a version that builds
none
try again! none

Description Filip Pizlo 2014-05-13 12:51:25 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2014-05-13 12:53:52 PDT
Created attachment 231402 [details]
the patch
Comment 2 Oliver Hunt 2014-05-13 12:57:56 PDT
Comment on attachment 231402 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231402&action=review

> Source/JavaScriptCore/assembler/MacroAssembler.h:200
> -
> +    

drop this :D
Comment 3 Filip Pizlo 2014-05-13 13:35:02 PDT
(In reply to comment #2)
> (From update of attachment 231402 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231402&action=review
> 
> > Source/JavaScriptCore/assembler/MacroAssembler.h:200
> > -
> > +    
> 
> drop this :D

Fixed, thanks!
Comment 4 Filip Pizlo 2014-05-13 15:11:34 PDT
Created attachment 231410 [details]
a version that builds
Comment 5 Filip Pizlo 2014-05-13 16:32:05 PDT
Created attachment 231417 [details]
try again!
Comment 6 Filip Pizlo 2014-05-13 20:58:01 PDT
Landed in http://trac.webkit.org/changeset/168776