Bug 132880

Summary: Add -[WKNavigationAction modifierFlags] and -[WKNavigationAction buttonNumber]
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Anders Carlsson
Reported 2014-05-13 12:09:18 PDT
Add -[WKNavigationAction modifierFlags] and -[WKNavigationAction buttonNumber]
Attachments
Patch (11.75 KB, patch)
2014-05-13 12:11 PDT, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-05-13 12:11:41 PDT
Created attachment 231398 [details] Patch
mitz
Comment 2 2014-05-13 12:19:03 PDT
Comment on attachment 231398 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231398&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm:39 > + bool _isUserInitiated; Please use BOOL and match the property name, _userInitiated. > Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h:45 > +- (instancetype)initWithNavigationActionData:(const WebKit::NavigationActionData&)navigationActionData; This internal method’s name needs an underscore prefix.
Anders Carlsson
Comment 3 2014-05-13 12:21:00 PDT
Committed r168690: <http://trac.webkit.org/changeset/168690>
Note You need to log in before you can comment on or make changes to this bug.