Bug 132880

Summary: Add -[WKNavigationAction modifierFlags] and -[WKNavigationAction buttonNumber]
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Description Anders Carlsson 2014-05-13 12:09:18 PDT 
Add -[WKNavigationAction modifierFlags] and -[WKNavigationAction buttonNumber]
Comment 1 Anders Carlsson 2014-05-13 12:11:41 PDT 
Created attachment 231398 [details]
Patch
Comment 2 mitz 2014-05-13 12:19:03 PDT 
Comment on attachment 231398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231398&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm:39
> +    bool _isUserInitiated;

Please use BOOL and match the property name, _userInitiated.

> Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h:45
> +- (instancetype)initWithNavigationActionData:(const WebKit::NavigationActionData&)navigationActionData;

This internal method’s name needs an underscore prefix.
Comment 3 Anders Carlsson 2014-05-13 12:21:00 PDT 
Committed r168690: <http://trac.webkit.org/changeset/168690>