Bug 132880 - Add -[WKNavigationAction modifierFlags] and -[WKNavigationAction buttonNumber]
Summary: Add -[WKNavigationAction modifierFlags] and -[WKNavigationAction buttonNumber]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-13 12:09 PDT by Anders Carlsson
Modified: 2014-05-13 12:21 PDT (History)
0 users

See Also:

Attachments
Patch (11.75 KB, patch)
2014-05-13 12:11 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-05-13 12:09:18 PDT 
Add -[WKNavigationAction modifierFlags] and -[WKNavigationAction buttonNumber]
Comment 1 Anders Carlsson 2014-05-13 12:11:41 PDT 
Created attachment 231398 [details]
Patch
Comment 2 mitz 2014-05-13 12:19:03 PDT 
Comment on attachment 231398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231398&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm:39
> +    bool _isUserInitiated;

Please use BOOL and match the property name, _userInitiated.

> Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h:45
> +- (instancetype)initWithNavigationActionData:(const WebKit::NavigationActionData&)navigationActionData;

This internal method’s name needs an underscore prefix.
Comment 3 Anders Carlsson 2014-05-13 12:21:00 PDT 
Committed r168690: <http://trac.webkit.org/changeset/168690>