Summary: | platform/mac/plugins/testplugin-onnew-onpaint.html failing after r168668 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon Honeycutt <jhoneycutt> | ||||
Component: | Tools / Tests | Assignee: | Jon Honeycutt <jhoneycutt> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 132621 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Jon Honeycutt
2014-05-13 11:07:48 PDT
Created attachment 231395 [details]
Patch
Comment on attachment 231395 [details]
Patch
r=me
Comment on attachment 231395 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231395&action=review > LayoutTests/ChangeLog:9 > + Make the test wait until plug-ins have loaded before finishing. Is onload expected to fire after plug-ins load? An honest question, I don't know if this test change is required for correctness, or if it is papering over a bug. I didn't mean to override the r+, but I think that this question is valid nonetheless. (In reply to comment #3) > (From update of attachment 231395 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231395&action=review > > > LayoutTests/ChangeLog:9 > > + Make the test wait until plug-ins have loaded before finishing. > > Is onload expected to fire after plug-ins load? An honest question, I don't know if this test change is required for correctness, or if it is papering over a bug. No, onload should be firing after plug-ins load. This is covered by <rdar://problem/16858476>. However, all tests expecting synchronous plug-in loading should've been updated as part of r168668. This is just bringing this test in line with the others. Landed in <http://trac.webkit.org/changeset/168743>. |