Summary: | ASSERTION FAILED: leftCategory != CalcOther && rightCategory != CalcOther in WebCore::CSSCalcBinaryOperation::createSimplified | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Hodovan <mhodovan.u-szeged> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, darin, esprehn+autocc, giles_joplin, glenn, gyuyoung.kim, kling, krit, macpherson, menard, simon.fraser | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 134059 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Martin Hodovan
2014-05-13 08:49:09 PDT
Created attachment 231384 [details]
Proposed patch
Comment on attachment 231384 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=231384&action=review > LayoutTests/ChangeLog:8 > + Added test contains calc() expressions with angle, time and frequency values, > + covering all the newly introduced unit types, each of which used to fail. But it doesn’t cover adding or subtracting combinations of these unit types, and the patch adds code to handle that. It doesn’t cover the behavior either. Need much more test coverage. I’d also like to see tests covering serialization of these kinds of style rules. Comment on attachment 231384 [details] Proposed patch Clearing flags on attachment: 231384 Committed r168685: <http://trac.webkit.org/changeset/168685> All reviewed patches have been landed. Closing bug. This caused bug 134059. |