Bug 132859

Summary: [CSS Regions] Assertion failure in some cases with inline blocks
Product: WebKit Reporter: Andrei Bucur <abucur>
Component: Layout and RenderingAssignee: Andrei Bucur <abucur>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker
Priority: P2 Keywords: AdobeTracked
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Repro
none
Patch
none
Patch
none
Patch with feedback none

Description Andrei Bucur 2014-05-13 02:19:43 PDT
See the attached repro.

If a line is pulled in a new region, the blocks contained by it don't clear the RenderBoxRegionInfo from the old region.
Comment 1 Andrei Bucur 2014-05-13 02:20:54 PDT
Created attachment 231365 [details]
Repro
Comment 2 Andrei Bucur 2014-05-13 06:54:36 PDT
Created attachment 231374 [details]
Patch
Comment 3 Andrei Bucur 2014-05-13 07:01:07 PDT
Created attachment 231376 [details]
Patch
Comment 4 Radu Stavila 2014-05-13 07:04:18 PDT
Comment on attachment 231376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231376&action=review

> Source/WebCore/rendering/RenderBlock.cpp:3877
> +bool RenderBlock::hasRegionRangeInFlowThread() const

Shouldn't this method be in RenderBox?
Comment 5 Andrei Bucur 2014-05-13 07:26:32 PDT
Created attachment 231379 [details]
Patch with feedback
Comment 6 Andrei Bucur 2014-05-13 07:27:00 PDT
D(In reply to comment #4)
> (From update of attachment 231376 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231376&action=review
> 
> > Source/WebCore/rendering/RenderBlock.cpp:3877
> > +bool RenderBlock::hasRegionRangeInFlowThread() const
> 
> Shouldn't this method be in RenderBox?

Done.
Comment 7 Mihnea Ovidenie 2014-05-13 07:52:33 PDT
Comment on attachment 231379 [details]
Patch with feedback

r=me
Comment 8 WebKit Commit Bot 2014-05-13 23:34:21 PDT
Comment on attachment 231379 [details]
Patch with feedback

Clearing flags on attachment: 231379

Committed r168791: <http://trac.webkit.org/changeset/168791>
Comment 9 WebKit Commit Bot 2014-05-13 23:34:25 PDT
All reviewed patches have been landed.  Closing bug.