Summary: | [Win] Correct Cygwin Path Confusion in WebInspectorUI Build | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||
Component: | Web Inspector | Assignee: | Brent Fulgham <bfulgham> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 132023 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Brent Fulgham
2014-05-12 10:25:33 PDT
Created attachment 231305 [details]
Patch
Comment on attachment 231305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231305&action=review r=me > Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:79 > +my $python = ($^O =~ /cygwin/) ? "/usr/bin/python" : "python"; Nit: Would be nice to have a more readable for of "$^O". Since off-hand I have no idea what it means. Comment on attachment 231305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231305&action=review >> Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:79 >> +my $python = ($^O =~ /cygwin/) ? "/usr/bin/python" : "python"; > > Nit: Would be nice to have a more readable for of "$^O". Since off-hand I have no idea what it means. s/for of/version of/ Created attachment 231306 [details]
Patch
Comment on attachment 231306 [details]
Patch
Much nicer! Thanks. r=me
Comment on attachment 231306 [details] Patch Clearing flags on attachment: 231306 Committed r168648: <http://trac.webkit.org/changeset/168648> All reviewed patches have been landed. Closing bug. |