Bug 132826

Summary: [Win] Correct Cygwin Path Confusion in WebInspectorUI Build
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Web InspectorAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 132023    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Brent Fulgham
Reported 2014-05-12 10:25:33 PDT
Cygwin's Python 2.7 requires very specific path handling to work around some nuances in the way the Python distribution is installed under Cygwin (see Bug 132023 for details, as well as <http://trac.webkit.org/changeset/167685>). This patch corrects another place in our build system where we are not explicit about where to find Python under Cygwin.
Attachments
Patch (3.26 KB, patch)
2014-05-12 10:28 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (3.39 KB, patch)
2014-05-12 10:35 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-05-12 10:26:25 PDT
<rdar://problem/16885618>
Radar WebKit Bug Importer
Comment 2 2014-05-12 10:26:28 PDT
<rdar://problem/16885619>
Brent Fulgham
Comment 3 2014-05-12 10:28:54 PDT
Created attachment 231305 [details] Patch
Joseph Pecoraro
Comment 4 2014-05-12 10:32:32 PDT
Comment on attachment 231305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231305&action=review r=me > Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:79 > +my $python = ($^O =~ /cygwin/) ? "/usr/bin/python" : "python"; Nit: Would be nice to have a more readable for of "$^O". Since off-hand I have no idea what it means.
Joseph Pecoraro
Comment 5 2014-05-12 10:33:01 PDT
Comment on attachment 231305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231305&action=review >> Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:79 >> +my $python = ($^O =~ /cygwin/) ? "/usr/bin/python" : "python"; > > Nit: Would be nice to have a more readable for of "$^O". Since off-hand I have no idea what it means. s/for of/version of/
Brent Fulgham
Comment 6 2014-05-12 10:35:25 PDT
Created attachment 231306 [details] Patch
Joseph Pecoraro
Comment 7 2014-05-12 10:38:42 PDT
Comment on attachment 231306 [details] Patch Much nicer! Thanks. r=me
WebKit Commit Bot
Comment 8 2014-05-12 15:20:05 PDT
Comment on attachment 231306 [details] Patch Clearing flags on attachment: 231306 Committed r168648: <http://trac.webkit.org/changeset/168648>
WebKit Commit Bot
Comment 9 2014-05-12 15:20:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.