Summary: | REGRESSION (r168119): Album flipping animation doesn’t work | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon Lee <jonlee> | ||||
Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dbates, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
URL: | http://scarey.org/albums/lp | ||||||
Attachments: |
|
Description
Jon Lee
2014-05-10 23:54:08 PDT
When applying the transform to flip, we're not doing layout so not updating the "m_hasTransformedAncestor" flags. Forcing layout when style changes between having a transform and not having one is not enough to fix this; we evaluate compositing at the start of the transition, when we've set the identity matrix on an ancestor (which will then animate to a 3D matrix). Also have to deal with animations that go from 2D -> 3D matrix. Created attachment 236148 [details]
Patch
Attachment 236148 [details] did not pass style-queue:
ERROR: Source/WebCore/rendering/RenderLayerCompositor.cpp:2395: Multi line control clauses should use braces. [whitespace/braces] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
|