Bug 132801

Summary: REGRESSION (r168119): Album flipping animation doesn’t work
Product: WebKit Reporter: Jon Lee <jonlee>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://scarey.org/albums/lp
Attachments:
Description Flags
Patch dino: review+

Jon Lee
Reported 2014-05-10 23:54:08 PDT
Go to: http://scarey.org/albums/lp and try to click on the album art to make it flip. The back cover flashes, then disappears. The front cover remains visible, rendered backward.
Attachments
Patch (7.65 KB, patch)
2014-08-06 15:54 PDT, Simon Fraser (smfr) 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-05-10 23:54:19 PDT
<rdar://problem/16878497>
Simon Fraser (smfr)
Comment 2 2014-05-11 11:37:11 PDT
When applying the transform to flip, we're not doing layout so not updating the "m_hasTransformedAncestor" flags.
Simon Fraser (smfr)
Comment 3 2014-05-11 12:21:57 PDT
Forcing layout when style changes between having a transform and not having one is not enough to fix this; we evaluate compositing at the start of the transition, when we've set the identity matrix on an ancestor (which will then animate to a 3D matrix).
Simon Fraser (smfr)
Comment 4 2014-05-11 13:47:00 PDT
Also have to deal with animations that go from 2D -> 3D matrix.
Simon Fraser (smfr)
Comment 5 2014-08-06 15:54:29 PDT
Created attachment 236148 [details] Patch
WebKit Commit Bot
Comment 6 2014-08-06 15:57:54 PDT
Attachment 236148 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderLayerCompositor.cpp:2395: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 7 2014-08-06 16:06:24 PDT
https://trac.webkit.org/r172183
Note You need to log in before you can comment on or make changes to this bug.